On Thu, Dec 5, 2019 at 6:31 PM Andrea Bolognani <[email protected]> wrote:
> On Mon, 2019-11-11 at 09:58 +0800, Han Han wrote: > > + <change> > > + <summary> > > + qemu: Support kvm-hint-dedicated performance hint > > + </summary> > > + <description> > > + With <code><hint-dedicated > state='on'/></code> and > > + <code><cpu mode='host-passthrough'/></code>, > it > > No need to use "'", a simple "'" will work just fine. > > > + allows a guest to enable optimizations when running on > dedicated > > + vCPUs. Qemu over <code>2.12</code> and kernel over > <code>4.17</code> > > s/Qemu/QEMU/ > > and the minimum version is 2.12.1 according to cb12c59dac04. > > Feature introduced version in commit msg cb12c59dac04 of is not correct here. Check that in qemu code, for the commit be7773268d target-i386: add KVM_HINTS_DEDICATED performance hint # git tag --contains=be7773268d|sort -n |head -n2 s v2.12.0 So the minimum version is v2.12.0 not v2.12.1 Fix it at https://www.redhat.com/archives/libvir-list/2019-December/msg00319.html > > With the nits mentioned above addressed, > > Reviewed-by: Andrea Bolognani <[email protected]> > > -- > Andrea Bolognani / Red Hat / Virtualization > > -- Best regards, ----------------------------------- Han Han Quality Engineer Redhat. Email: [email protected] Phone: +861065339333
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
