On 12/10/19 12:43 AM, Cole Robinson wrote:
On 12/2/19 9:26 AM, Michal Privoznik wrote:
To simplify implementation, some restrictions are added. For
instance, an NVMe disk can't go to any bus but virtio and has to
be type of 'disk' and can't have startupPolicy set.

Signed-off-by: Michal Privoznik <mpriv...@redhat.com>

Reviewed-by: Cole Robinson <crobi...@redhat.com>

Arguably the nvme->namespace == 0 should be in a Validate callback, but
it's extremely minor

Fixed. Initially, I thought that namespace == 0 is invalid XML but I can argue both ways. And since you have inclination to the Validate callback I've moved the check there.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to