On Fri, Dec 13, 2019 at 03:00 PM -0500, Cole Robinson <crobi...@redhat.com> wrote: > On 12/12/19 9:13 AM, Marc Hartmayer wrote: >> On Wed, Dec 11, 2019 at 07:48 PM -0500, Cole Robinson <crobi...@redhat.com> >> wrote: >>> On 11/14/19 12:44 PM, Marc Hartmayer wrote: >>>> To free the structs and save the error, it is not necessary to hold >>>> @priv->lock, >>>> therefore move these parts after the mutex unlock. >>>> >>>> Signed-off-by: Marc Hartmayer <mhart...@linux.ibm.com> >>>> --- >>>> src/remote/remote_daemon_dispatch.c | 32 ++++++++++++++--------------- >>>> 1 file changed, 16 insertions(+), 16 deletions(-) >>> >>> Reviewed-by: Cole Robinson <crobi...@redhat.com> >>> >>> Do I understand correctly that 1,3-5 are all independent and can be >>> pushed separately? If so I will do that tomorrow. I'm doing some >>> archaeology on patch #2 >> >> 1, 3, and 5 are all independent. >> >> Patch 4 depends on the second patch as >> remoteDispatchConnectRegisterCloseCallback uses >> virConnectRegisterCloseCallback. Otherwise we would never do the unref >> for @client and @program when conn->driver->connectRegisterCloseCallback >> was NULL. > > Thanks, I pushed 1, 3, 5, 6. I'll reply to your other message > > - Cole >
Thanks. -- Kind regards / Beste Grüße Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Matthias Hartmann Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
