On Tue, Jan 07, 2020 at 04:50:19PM +0100, Andrea Bolognani wrote:
> Right now we're looping in the wrong place: instead of
> unconditionally adding to the flattened list of pip packages and
> then calling pip multiple times with that same list, we should
> conditionally add items to the flattened list and then call pip
> a single time with the result.
> 
> Signed-off-by: Andrea Bolognani <[email protected]>
> ---
>  guests/playbooks/update/tasks/packages.yml | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)

Reviewed-by: Daniel P. Berrangé <[email protected]>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to