On Wed, Mar 25, 2020 at 5:08 PM Fabiano Fidêncio <fiden...@redhat.com> wrote: > > On Wed, Mar 25, 2020 at 4:51 PM Felipe Borges <felipebor...@gnome.org> wrote: > > > > Signed-off-by: Felipe Borges <febor...@redhat.com> > > --- > > libvirt-gobject/libvirt-gobject-domain.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libvirt-gobject/libvirt-gobject-domain.c > > b/libvirt-gobject/libvirt-gobject-domain.c > > index 399b118..0a16cb4 100644 > > --- a/libvirt-gobject/libvirt-gobject-domain.c > > +++ b/libvirt-gobject/libvirt-gobject-domain.c > > @@ -777,7 +777,7 @@ gvir_domain_save_to_file_helper(GTask *task, > > * @filename: path to output file > > * @custom_conf: (allow-none): configuration for domain or NULL > > * @flags: the flags > > - * @cancellable: (allow-none) (transfer none): cancallation object > > + * @cancellable: (allow-none) (transfer none): cancellation object > > * @callback: (scope async): completion callback > > * @user_data: (closure): opaque data for callback > > * > > -- > > 2.24.1 > > > > > > For both patches ... > Reviewed-by: Fabiano Fidêncio <fiden...@redhat.com> > ... and pushed. >
Hi, thanks for the quick review! > Do you need a release including 2nd patch in order to unblock > something for Boxes on Fedora 32? No need. I patched Boxes directly by hardcoding the flag value. https://src.fedoraproject.org/rpms/gnome-boxes/blob/f32/f/0001-libvirt-machine-Pass-VIR_DOMAIN_UNDEFINE_NVRAM-while.patch#_22 It would be nice to have a release before Fedora 33, but for that we have plenty of time, so no worries. Cheers! Felipe Borges. > > Best Regards, > -- > Fabiano Fidêncio >
