Hi Daniel, Thanks for reviewing. :-) IMHO, I don't like to join them in one single patch because it is hard to review. I know that others have a different opinion (and it is good). But I will think about it for v3.
-- Julio Cesar Faracco Em qua., 22 de abr. de 2020 às 08:05, Daniel Henrique Barboza <[email protected]> escreveu: > > > > On 4/21/20 1:03 AM, Julio Faracco wrote: > > If an user is trying to configure a dhcp neetwork settings, it is not > > s/neetwork/network > > > > This patch failed to compile in my box on top of master at 9a13704818e: > > > CCLD libvirdeterministichashmock.la > ../../tests/networkxml2conftest.c: In function 'testCompareXMLToConfFiles': > ../../tests/networkxml2conftest.c:46:59: error: passing argument 4 of > 'networkDnsmasqConfContents' from incompatible pointer type > [-Werror=incompatible-pointer-types] > 46 | if (networkDnsmasqConfContents(obj, pidfile, &actual, dctx, > caps) < 0) > | ^~~~ > | | > | > dnsmasqContext * {aka struct <anonymous> *} > In file included from ../../tests/networkxml2conftest.c:13: > ../../src/network/bridge_driver.h:49:35: note: expected 'char **' but > argument is of type 'dnsmasqContext *' {aka 'struct <anonymous> *'} > 49 | char **hostsfilestr, > | ~~~~~~~^~~~~~~~~~~~ > ../../tests/networkxml2conftest.c:46:65: error: passing argument 5 of > 'networkDnsmasqConfContents' from incompatible pointer type > [-Werror=incompatible-pointer-types] > 46 | if (networkDnsmasqConfContents(obj, pidfile, &actual, dctx, > caps) < 0) > | ^~~~ > | | > | > dnsmasqCapsPtr {aka struct _dnsmasqCaps *} > In file included from ../../tests/networkxml2conftest.c:13: > ../../src/network/bridge_driver.h:50:44: note: expected 'dnsmasqContext *' > {aka 'struct <anonymous> *'} but argument is of type 'dnsmasqCapsPtr' {aka > 'struct _dnsmasqCaps *'} > 50 | dnsmasqContext *dctx, > | ~~~~~~~~~~~~~~~~^~~~ > ../../tests/networkxml2conftest.c:46:9: error: too few arguments to function > 'networkDnsmasqConfContents' > 46 | if (networkDnsmasqConfContents(obj, pidfile, &actual, dctx, > caps) < 0) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from ../../tests/networkxml2conftest.c:13: > ../../src/network/bridge_driver.h:46:1: note: declared here > 46 | networkDnsmasqConfContents(virNetworkObjPtr obj, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > > > > Thanks, > > > DHB
