Hi Andrea,

Thank you for the review.

On 6/3/20 12:11 PM, Andrea Bolognani wrote:
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote:
Add test to verify ZPCI address validation with uid set to 0x0

Signed-off-by: Bjoern Walk <[email protected]>
Signed-off-by: Shalini Chellathurai Saroja <[email protected]>
Reviewed-by: Bjoern Walk <[email protected]>
Reviewed-by: Boris Fiuczynski <[email protected]>
---
  .../hostdev-vfio-zpci-uid-set-zero.xml        | 20 +++++++++++++++++++
  tests/qemuxml2argvtest.c                      |  3 +++
  2 files changed, 23 insertions(+)
  create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-zpci-uid-set-zero.xml
The test cases for the new behavior should go into the patch that
implements it.
ok.

+++ b/tests/qemuxml2argvtest.c
@@ -1650,6 +1650,9 @@ mymain(void)
      DO_TEST("hostdev-vfio-zpci-autogenerate",
              QEMU_CAPS_DEVICE_VFIO_PCI,
              QEMU_CAPS_DEVICE_ZPCI);
+    DO_TEST_PARSE_ERROR("hostdev-vfio-zpci-uid-set-zero",
+            QEMU_CAPS_DEVICE_VFIO_PCI,
+            QEMU_CAPS_DEVICE_ZPCI);
Indentation is off.
ok, I will correct it.


Reply via email to