On 6/15/20 12:10 PM, Peter Krempa wrote:
Exercise the now arguably simpler checkpoint deletion code on the
'basic', 'snapshots', and 'synthetic' test data sets.

Signed-off-by: Peter Krempa <[email protected]>
---
  tests/qemublocktest.c                         | 18 ++++++++
  .../checkpointdelete/basic-current-out.json   |  9 ++++
  .../basic-intermediate1-out.json              |  9 ++++
  .../basic-intermediate2-out.json              |  9 ++++
  .../basic-intermediate3-out.json              |  9 ++++
  .../checkpointdelete/basic-noparent-out.json  |  9 ++++
  .../snapshots-current-out.json                |  9 ++++
  .../snapshots-intermediate1-out.json          | 26 ++++++++++++
  .../snapshots-intermediate2-out.json          | 26 ++++++++++++
  .../snapshots-intermediate3-out.json          | 18 ++++++++
  .../snapshots-noparent-out.json               | 42 +++++++++++++++++++
  .../synthetic-current-out.json                |  9 ++++
  .../synthetic-intermediate1-out.json          | 11 +++++
  .../synthetic-intermediate2-out.json          | 11 +++++
  .../synthetic-intermediate3-out.json          | 19 +++++++++
  .../synthetic-noparent-out.json               | 11 +++++

Looks reasonable; you're deleting the bitmap across all files in the chain where it appears, and don't have to mess around with which bitmaps to re-enable or merge into.

Reviewed-by: Eric Blake <[email protected]>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Reply via email to