On 7/15/20 8:10 AM, Peter Krempa wrote:
Top level image may get two events, one with the disk target (vda) and
one with disk target with index (vda[3]) if the top level image has an
index.

Signed-off-by: Peter Krempa <pkre...@redhat.com>
---
  src/libvirt-domain.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index ba30d18f65..6c5ff5b0db 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -12370,6 +12370,10 @@ int virDomainGetGuestInfo(virDomainPtr domain,
   * described by @dev is written beyond the set threshold level. The threshold
   * level is unset once the event fires. The event might not be delivered at 
all
   * if libvirtd was not running at the moment when the threshold was reached.
+ * Note that if the threshold level is reached for a top level image the event

s/image/image,/

+ * is emitted for @dev corresponding to the disk target, and may also be 
reported
+ * with @dev corresponding to the disk target with an index corresponding to 
the
+ * 'index' attribute of 'source' in the live VM XML if the atribute is present.

attribute

   *
   * @dev can either be a disk target name (vda, sda) or disk target with index 
(
   * vda[4]). Without the index the top image in the backing chain will have the


With fixes,
Reviewed-by: Eric Blake <ebl...@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Reply via email to