Re: [libvirt PATCH 0/2] util: avoid race in glib event loop which causes crashes

[Michal Privoznik]

On 7/29/20 6:10 PM, Daniel P. Berrangé wrote:

A while ago Cole reported that libvirt is exposing a long
term bug in GLib's event loop that results in non-deterministic
crashes:

   https://www.redhat.com/archives/libvir-list/2020-February/msg00422.html

I kept forgetting to investigate it until now.

Daniel P. Berrangé (2):
   util: keep track of full GSource object not source ID number
   util: avoid crash due to race in glib event loop code

  src/rpc/virnetclient.c       | 27 ++++++-----
  src/util/vireventglib.c      | 91 +++++++++++++++++++++++++-----------
  src/util/vireventglibwatch.c | 19 ++++----
  src/util/vireventglibwatch.h | 13 +++---
  4 files changed, 97 insertions(+), 53 deletions(-)

Reviewed-by: Michal Privoznik <mpriv...@redhat.com>

Michal