On Mon, 2020-10-05 at 12:33 -0400, Neal Gompa wrote: > On Mon, Oct 5, 2020 at 6:18 AM Andrea Bolognani <[email protected]> wrote: > > On Sun, 2020-10-04 at 22:16 -0400, Neal Gompa wrote: > > > +++ b/libvirt.spec.in > > > +# Xen is available only on i386 x86_64 ia64 aarch64 > > > +%ifnarch %{ix86} x86_64 ia64 aarch64 > > > %define with_libxl 0 > > > %endif > > > > The code change is okay, but duplicating the list of architectures in > > the comment is kinda pointless and results in unnecessary churn; I > > would reword it as > > > > Xen is available only on some architectures > > > > Are you okay with that change? If so, I will add my > > > > Reviewed-by: Andrea Bolognani <[email protected]> > > > > and push the patch. > > I'm fine with that. I debated making that change myself, too. :)
Fixed the obvious conflict with commit 5eb6d5401ded7896d6f5b30c10499157a08d6833 Author: Daniel P. Berrangé <[email protected]> Date: Mon Oct 5 13:17:02 2020 +0100 rpm: drop ia64, sparc64 and alpha architectures None of these arches are relevant to current Fedora or RHEL distros. Reviewed-by: Andrea Bolognani <[email protected]> Signed-off-by: Daniel P. Berrangé <[email protected]> adjusted the comment as agreed and pushed. -- Andrea Bolognani / Red Hat / Virtualization
