> On Oct 21, 2020, at 7:01 AM, Michal Privoznik <[email protected]> wrote:
> 
> On 10/21/20 10:46 AM, Matt Coleman wrote:
>> 
>> +    if (hypervInvokeMethod(priv, &params, NULL) < 0) {
>> +        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could not set 
>> autostart"));
> 
> No need to report error here because hypervInvokeMethod() already reported 
> one for us. And unfortunately we don't have stacked error messages, so this 
> would just overwrite the error reported earlier.

I keep forgetting that this overwrites any previously-reported error. Feel free 
to remove this, or I can do it in a later commit.

-- 
Matt


Reply via email to