Re: [PATCH 0/7] qemu: Add workaround for apps polling virDomainGetBlockJobInfo with pre-blockdev qemu

[Michal Privoznik]

On 12/4/20 4:07 PM, Peter Krempa wrote:

This is a workaround for the issue that Nikolay tries to fix in:

https://www.redhat.com/archives/libvir-list/2020-November/msg00669.html

This one is a far more focused hack for apps which don't bother to
update to events for block job completion checking.

Peter Krempa (7):
   virDomainGetBlockJobInfo: Discourage polling for block job completion
     detection
   virDomainGetBlockJobInfo: Reword docs for fallback values
   qemuMonitorBlockJobInfo: Store 'ready' and 'ready_present' separately
   qemuBlockJobInfoTranslate: Use explicit comparison against 0
   qemuDomainGetBlockJobInfo: Use qemuMonitorGetAllBlockJobInfo
   qemu: monitor: Remove unused qemuMonitorGetBlockJobInfo
   qemuDomainGetBlockJobInfo: Work stats for unfinished pre-blockdev
     blockjob

  src/libvirt-domain.c         | 23 +++++++++++++++------
  src/qemu/qemu_driver.c       | 39 +++++++++++++++++++++++-------------
  src/qemu/qemu_monitor.c      | 29 ---------------------------
  src/qemu/qemu_monitor.h      |  7 ++-----
  src/qemu/qemu_monitor_json.c |  8 ++------
  src/qemu/qemu_process.c      |  4 ++--
  6 files changed, 48 insertions(+), 62 deletions(-)

Reviewed-by: Michal Privoznik <mpriv...@redhat.com>

Michal