Re: [PATCH] virNetDevOpenvswitchGetVhostuserIfname: Remove a single '\n' from ifname

[Yalei Li]

Thank you.
Does this patch need other reviews ?


On 1/22/21 7:26 AM, Yalei Li wrote:
> Ovs-vsctl returns a newline result.
&gt; Signed-off-by: Yalei Li <liy...@chinatelecom.cn&gt;
&gt; ---

Reviewed-by: Daniel Henrique Barboza <danielhb...@gmail.com&gt;

&gt;&nbsp;&nbsp; src/util/virnetdevopenvswitch.c | 1 +
&gt;&nbsp;&nbsp; 1 file changed, 1 insertion(+)
&gt; 
&gt; diff --git a/src/util/virnetdevopenvswitch.c 
b/src/util/virnetdevopenvswitch.c
&gt; index f9b3369b2a..bd840bd3b7 100644
&gt; --- a/src/util/virnetdevopenvswitch.c
&gt; +++ b/src/util/virnetdevopenvswitch.c
&gt; @@ -575,6 +575,7 @@ virNetDevOpenvswitchGetVhostuserIfname(const char 
*path,
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return 0;
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&nbsp;&nbsp; 
&gt; +&nbsp;&nbsp;&nbsp; virStringTrimOptionalNewline(*ifname);
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if 
(virNetDevOpenvswitchMaybeUnescapeReply(*ifname) < 0) {
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
VIR_FREE(*ifname);
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;