Re: [libvirt PATCH v6 11/30] nodedev: add mdevctl devices to node device list

[Erik Skultety]

On Fri, Mar 26, 2021 at 11:48:07AM -0500, Jonathon Jongsma wrote:
> At startup, query devices that are defined by 'mdevctl' and add them to
> the node device list.
> 
> This adds a complication: we now have two potential sources of
> information for a node device:
>  - udev for all devices and for activated mediated devices
>  - mdevctl for persistent mediated devices
> 
> Unfortunately, neither backend returns full information for a mediated
> device. For example, if a persistent mediated device in the list (with
> information provided from mdevctl) is 'started', that same device will
> now be detected by udev. If we simply overwrite the existing device
> definition with the new one provided by the udev backend, we will lose
> extra information that was provided by mdevctl (e.g. attributes, etc).
> To avoid this, make sure to copy the extra information into the new
> device definition.
> 
> Signed-off-by: Jonathon Jongsma <jjong...@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskul...@redhat.com>