Re: [libvirt PATCH v2 02/12] nodedev: avoid use of VIR_ERR_NO_* errors internally

[Erik Skultety]

On Tue, Apr 13, 2021 at 03:39:38PM -0500, Jonathon Jongsma wrote:
> These errors are demoted to debug statements[1] since they're only
> intended to be used as return values for public APIs.  This makes it
> difficult to debug the problem when something goes wrong since no error
> message is logged. Switch instead to VIR_ERR_INTERNAL_ERROR so that the
> error is logged as expected.
> 
> [1] See the implementation of daemonErrorLogFilter() for details:
> https://gitlab.com/libvirt/libvirt/-/blob/e2f82a3704f680fbb37a733476d870c19232c23e/src/remote/remote_daemon.c#L89
> 
> Signed-off-by: Jonathon Jongsma <jjong...@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskul...@redhat.com>