On Mon, Jul 12, 2021 at 11:16:50AM +0800, Luke Yue wrote:
On Fri, 2021-07-09 at 15:10 +0200, Martin Kletzander wrote:On Wed, Jun 30, 2021 at 10:53:44AM +0800, Luke Yue wrote: > Signed-off-by: Luke Yue <luked...@gmail.com> > --- > src/test/test_driver.c | 53 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) >If you first abstract the code from qemu driver then there's less code move to add this functionality. Also one more thing to check is whether qemu driver is the only one that has this code and that it is not duplicated anywhere else - we could dedup even more code ;)Thanks! But I'm sorry that I find out that qemu driver seems to be the only one that has this code (what I extracted to virDomainObjGetMessages), do I miss something? Or it's just a general suggestion for future development work?
Just a general suggestion. I did not know whether qemu driver is the only one that has this code or not, but since you checked you already did what I suggested ;) I'd still switch it around and first abstract the qemu code and then implement the test driver one.
signature.asc
Description: PGP signature
