On Wed, Jul 21, 2021 at 10:54 PM Michal Prívozník <mpriv...@redhat.com> wrote:
> > > The bug quoted shows a few examples where we fail to save status. > > > > I'm very surprised we don't save status when hotplugging a NIC or a > > disk, as the BZ suggests. > > I'm not convinced that the steps there are 100% correct. We do call > virDomainObjSave() after live attach: > > > https://gitlab.com/libvirt/libvirt/-/blob/master/src/qemu/qemu_driver.c#L7834 > > The two steps for hot-unplug in the BZ actually failed. (sorry I didn't mention the result in the steps) > > > > Missing status save in QMP monitor command passthrough is less > > surprising though since we're not actually changing the VM state > > when doing that, so would not have reason to save state except > > for the taint message. > > Yep. For a few cases it is hidden in BeginJob() and EndJob() but not for > agent jobs. > > Michal > >