Re: [PATCH 3/6] api: add virNetworkCreateFlags

[Ján Tomko]

On a Thursday in 2021, Kristina Hanicova wrote:

Signed-off-by: Kristina Hanicova <khani...@redhat.com>
---
include/libvirt/libvirt-network.h | 4 ++++
src/libvirt-network.c             | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/libvirt/libvirt-network.h 
b/include/libvirt/libvirt-network.h
index 0be4d64b75..d8eaf83d93 100644
--- a/include/libvirt/libvirt-network.h
+++ b/include/libvirt/libvirt-network.h
@@ -113,6 +113,10 @@ virNetworkPtr           virNetworkLookupByUUID          
(virConnectPtr conn,
virNetworkPtr           virNetworkLookupByUUIDString    (virConnectPtr conn,
                                                         const char *uuid);

+typedef enum {
+    VIR_NETWORK_CREATE_VALIDATE = 1 << 0, /* Validate the XML document against 
schema */

I'd write this as:
  VIR_NETWORK_CREATE_VALIDATE = VIR_NETWORK_DEFINE_VALIDATE,
to make it obvious we use them interchangeably.

Jano

+} virNetworkCreateFlags;
+
/*
 * Create active transient network
 */

signature.asc
Description: PGP signature