Re: [PATCH 00/20] qemuxml2argvtest: Cleanup and modernize disk-related (and other) tests

[Ján Tomko]

On a Wednesday in 2021, Peter Krempa wrote:

This series cleans up disk related tests and ensures that all use real
capabilities.

This is preparation for an upcoming RFC patch adding real caps test for
everything.

Peter Krempa (20):
 testCompareXMLToArgv: Avoid use of uninitialized 'monitor_chr'
 testQemuInfoInitArgs: Report error if path to 'latest' caps for an
   arch is NULL
 qemuxml2argvtest: Remove 'boot-strict' case
 qemuxml2argvtest: Agregate all 'disk'-related test cases
 qemuxml2argvtest: Remove fake caps versions of disk tests we have a
   versioned test for
 qemuxml2argvtest: Remove negative case for 'luks-disks-source-qcow2'
 qemuxml2argvtest: Remove 'disk-usb-nosupport' case
 qemuxml2argvtest: Convert encrypted disk test cases to
   DO_TEST_CAPS_LATEST
 qemuxml2argvtest: Use DO_TEST_CAPS_LATEST_PARSE_ERROR for disk cases
 qemuxml2argvtest: Use real caps for all disk frontend property tests
 qemuxml2argvtest: Replace 'disk-network-iscsi' by the more
   comprehensive 'disk-network-iscsi-modern'
 qemuxml2argvtest: Merge 'disk-iscsi' case into 'disk-cache'
 qemuxml2argvtest: Modernize 'disk-network-rbd-no-colon' case
 qemuxml2argvtest: Modernize outstanding disk-backend related tests
 qemuxml2argvtest: Modernize 'disk-floppy-pseries' case
 qemuxml2argvtest: Modernize s390x disk tests
 tests: qemu: Remove 'virtio-ccw' machine type from fake capabilities
 qemuxml2argvtest: Use versioned ("4.1.0") capabilities for pre
   '-audiodev' cases
 qemuxml2argvtest: Pin old-style '-no-reboot' usage to qemu-5.2
 qemuxml2argvtest: remove 'fs9p' cases with fake capabilities.

.../qemuhotplug-base-ccw-live+ccw-virtio.xml  |   2 +-
...ith-2-ccw-virtio+ccw-virtio-1-explicit.xml |   2 +-

[...]

.../hostdev-scsi-vhost-scsi-ccw.xml           |   2 +-
.../iothreads-disk-virtio-ccw.xml             |   2 +-
tests/testutilsqemu.c                         |   8 +-
181 files changed, 1726 insertions(+), 2164 deletions(-)
rename tests/qemuxml2argvdata/{audio-alsa-best.args => 
audio-alsa-best.x86_64-4.1.0.args} (81%)
rename tests/qemuxml2argvdata/{audio-alsa-full.err => 
audio-alsa-full.x86_64-4.1.0.err} (100%)

[...]

With the machine type fixed in two commit messages:

Reviewed-by: Ján Tomko <jto...@redhat.com>

Jano

signature.asc
Description: PGP signature