On 03/31/2010 10:38 AM, Eric Blake wrote: > Hmm, thinking aloud here: your patch series has introduced several > instances of checking STRPREFIX, then advancing to the end of the > prefix. Maybe it's time to introduce a helper macro that does both the > check and advances the pointer to the end of the match? Something like: > > #define STPCMP(ptr, cmp) \ > (STRPREFIX (*(ptr), cmp) ? (ptr) += strlen (cmp) : NULL) > > STPCMP(&tmp, " : "); > if (tmp == NULL) > error... > else > use tmp...
More thinking aloud - that looks a bit confusing compared to other stp*
interfaces. Maybe:
#define STPCMP(str, cmp) \
(STRPREFIX (str, cmp) ? (str) + strlen (cmp) : NULL)
if ((tmp = STPCMP(tmp, " : ") == NULL)
error...
else
use tmp...
--
Eric Blake [email protected] +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
