On Thu, Sep 01, 2022 at 14:47:39 +0200, Jiri Denemark wrote:
> Let's call this qemuMigrationSrcCancelUnattended as the function is
> supposed to be used when no other thread is watching the migration.
>
> Signed-off-by: Jiri Denemark <[email protected]>
> ---
> src/qemu/qemu_migration.c | 2 +-
> src/qemu/qemu_migration.h | 2 +-
> src/qemu/qemu_process.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index b3b25d78b4..67d83ca743 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -6943,7 +6943,7 @@ qemuMigrationSrcToFile(virQEMUDriver *driver,
> virDomainObj *vm,
>
>
> int
Maybe you should also add a function description here so that it's
obvious. Or at least that the docs don't stay in the commit message
only.
> -qemuMigrationSrcCancel(virDomainObj *vm)
> +qemuMigrationSrcCancelUnattended(virDomainObj *vm)
> {
> qemuDomainObjPrivate *priv = vm->privateData;
> bool storage = false;
Reviewed-by: Peter Krempa <[email protected]>
