Internal disk snapshots are currently only supported on non-active VMs. This patch series extends this support for active VMs running with qemu.
This implementation for the qemu driver works even when there are other disks which ask for external snapshot. Thus we remove the restriction disallowing mixing of internal and external disk snapshots for active VMs. Note that mixing is still disallowed for non-active VMs, as it require a bit more work in a different area of the code. Additionally we add a new attribute to allow the user specifying a unique snapshot name for each internal disk snapshot. In case this optional attribute is not specified, snapshot name will be taken from the domain snapshot name, as it is currently done today. Or Ozeri (4): conf: add snapshotName attribute for internal disk snapshot qemu: Support active disk internal snapshots qemu: allow mixing active internal and external active disk snapshots qemu: switch offline internal disk snapshots to use snapshotName docs/formatsnapshot.rst | 5 ++ src/conf/schemas/domainsnapshot.rng | 4 + src/conf/snapshot_conf.c | 27 ++++++ src/conf/snapshot_conf.h | 2 + src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_monitor.c | 9 ++ src/qemu/qemu_monitor.h | 5 ++ src/qemu/qemu_monitor_json.c | 14 +++ src/qemu/qemu_monitor_json.h | 5 ++ src/qemu/qemu_snapshot.c | 88 +++++++++++-------- .../disk_snapshot.xml | 2 +- .../disk_snapshot.xml | 2 +- .../disk_snapshot_redefine.xml | 2 +- tests/qemumonitorjsontest.c | 1 + 14 files changed, 125 insertions(+), 43 deletions(-) -- 2.25.1
