On Tue, Sep 19, 2023 at 11:15:05AM +0200, Erik Skultety wrote:
> Unfortunately, once we go down the line of running our own scripts as
> part of GitLab CI jobs rather than open coding Shell in YAML, we lose
> the benefit of seeing each line the script executes. The downside of
> the default YAML however is that we have to maintain the same piece of
> code on 2 places in that case. Let's adopt what we use with other
> container jobs and prefix each shell command with 'run_cmd' or
> 'run_cmd_quiet' which will dump it in the logs before executing.
> Flow control expressions and structures are a problem though in this
> regard, so let's just print some important values for debugging
> purposes.
> 
> Signed-off-by: Erik Skultety <eskul...@redhat.com>
> ---
>  ci/jobs.sh | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)

Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Reply via email to