On 08/19/2010 03:44 PM, Matthias Bolte wrote: > 2010/8/19 Eric Blake <[email protected]>: >> * src/vbox/vbox_tmpl.c (vboxDomainCreateWithFlags): Split... >> (vboxStartMachine): ...into new helper. >> --- >> >> This function was just too unbearable with that much nested indentation. >> This should be a no-op refactoring. > > Looks fine and I can still start a VirtualBox guest after applying this patch. > >> vboxDomainDefineXML is even worse, and contains the remaining sprintf >> instances in this file; I'll probably try to factor that one down as well. > > Yes, unfortunately the driver code has many indentation levels and > large functions in several places. > > ACK.
Thanks; pushed. I'm working on splitting vboxDomainDefineXML before tackling the sprintf uses in this file. -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
