2011/1/4 Eric Blake <[email protected]>: > On 12/30/2010 10:14 AM, Matthias Bolte wrote: >> Update test suite accordingly. > >> + >> + virBufferVSprintf(buffer, "svga.vramSize = \"%d\"\n", >> + def->vram * 1024); /* Scale from kilobytes to bytes */ > > Should this be %lld, def->vram * 1024ll, to avoid overflow concerns?
Sure, doesn't hurt to do so. > Otherwise, it looks okay to me. Conditional ACK based on the answer to > that question. Thanks, I folded in the LL suggestion and pushed the result. Matthias -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
