Hi Lyre,

> +             set_error ("Cannot find storage pool" TSRMLS_CC);


This is being set by the function itself and caught using the
catch_error() so please avoid this line in v2 of the patch.


> +     volume=virStorageVolLookupByPath (conn->conn,name);
> +     if (volume==NULL)
> +     {
> +             set_error ("Cannot find volume");
> +             RETURN_FALSE;
> +     }


Same here.

Thanks,
Michal

-- 
Michal Novotny <[email protected]>, RHCE
Virtualization Team (xen userspace), Red Hat

--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to