On 04/28/2011 11:53 AM, Jim Fehlig wrote: > The xend driver will generate a virDomainNetDef ifname if one is not > specified in xend sexpr, even if domain is inactive. The result is > network interface XML containing 'vif-1.Y' on dev attribute of target > element, e.g. > > <interface type='bridge'> > <target dev='vif-1.0'/> > ... > > This patch changes the behavior to only generate the ifname if not > specified in xend sexpr *and* domain is not inactive (id != -1).
Makes sense for the rationale. However...
> + } else if (def->id != -1) {
> snprintf(buf, sizeof(buf), "vif%d.%d", def->id, vif_index);
> - tmp = buf;
> + if (!(net->ifname = strdup(buf)))
Rather than using snprintf and strdup, can't we just use:
if (virAsprintf(&net->ifname, "vif%d.%d", def->id, vif_index) < 0)
goto no_memory;
--
Eric Blake [email protected] +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
