2011/5/18 Eric Blake <[email protected]>: > Regression introduced in commit 53cb23f4. > > * configure.ac: Let --with-python default to check. > --- > > v2: no change from v1 > v1: https://www.redhat.com/archives/libvir-list/2011-May/msg00412.html > > configure.ac | 29 ++++++++++++++++++++--------- > 1 files changed, 20 insertions(+), 9 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 8a3de4c..1a9fddd 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1832,12 +1832,12 @@ dnl check for python > dnl > > AC_ARG_WITH([python], > - AC_HELP_STRING([--with-python], [Build python bindings > @<:@default=yes@:>@]),[],[with_python=yes]) > + AC_HELP_STRING([--with-python], > + [Build python bindings @<:@default=check@:>@]),[],[with_python=check]) > > if test "$enable_shared:$with_python" = no:yes; then > - AC_MSG_WARN([Disabling shared libraries is incompatible with building > Python extensions.]) > - AC_MSG_WARN([Ignoring --with-python.]) > - with_python=no > + AC_MSG_ERROR([Disabling shared libraries is incompatible with building > + Python extensions.]) > fi
So, now this reports an error when you explicitly enable Python bindings. But as with_python defaults to check now we might end up enabling the bindings after this check even though enable_shared is no. So this check doesn't work correctly anymore. Matthas -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
