On Wed, Aug 10, 2011 at 16:37:26 +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <[email protected]> > > In some cases the caller of virPidFileRead might like extra checks > to determine whether the pid just read is really the one they are > expecting. This adds virPidFileReadIfValid which will check whether > the pid is still alive with kill(0, -1), and (on linux only) will > look at /proc/$PID/path > > * libvirt_private.syms, util/virpidfile.c, util/virpidfile.h: Add > virPidFileReadIfValid and virPidFileReadPathIfValid > * network/bridge_driver.c: Use new APIs to check PID validity
The commit message talks about *IfValid while the code implements *IfAlive. I think we should be consistent :-) ACK Jirka -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
