On Thu, Jan 19, 2012 at 02:13:59PM +0100, Michal Novotny wrote: > This patch introduces a new structure called virErrorsPtr which can get all > the errors that occurred since the connection open. The error callback > function > is being used as many times as necessary. The new public function called > virGetAllErrors() has been introduced to get all the errors that occurred.
This impl is effectively an unbounded memory leak, if you consider that applications will keep the same virConnectPtr open more or less forever. In addition any libvirt API that raises multiple errors should be considered broken, so I don't think we should have any such API for querying multiple errors. What is the situation that motivated this new API ? Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
