Dňa 27.3.2012 16:37, Eric Blake wrote / napísal(a):
Commit d42a2ff caused a regression in creating a disk-only snapshot
of a qcow2 disk; by passing the wrong variable to the monitor call,
libvirt ended up creating JSON that looked like "format":null instead
of the intended "format":"qcow2".
To make it easier to diagnose this in the future, make JSON creation
error out if "s:arg" is paired with NULL (it is still possible to
use "n:arg" in the rare cases where qemu will accept a null).
* src/qemu/qemu_driver.c
(qemuDomainSnapshotCreateSingleDiskActive): Pass correct value.
* src/qemu/qemu_monitor_json.c (qemuMonitorJSONMakeCommandRaw):
Improve error message.
---
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_monitor_json.c | 6 ++++++
2 files changed, 7 insertions(+), 1 deletions(-)
Definitely a better solution. ACK
Peter
--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list
