On 08/01/2012 05:34 AM, Ján Tomko wrote: > capability.rng: Guest features can be in any order. > nodedev.rng: Added <driver> element, <capability> phys_function and > virt_functions for PCI devices. > storagepool.rng: Owner or group ID can be -1. > --- > docs/schemas/capability.rng | 76 +++++++++++++++++++++-------------------- > docs/schemas/nodedev.rng | 37 ++++++++++++++++++++ > docs/schemas/storagepool.rng | 4 +- > 3 files changed, 78 insertions(+), 39 deletions(-)
Nice, but incomplete. It would help if we had some new sample files
somewhere in the tests directory so that the various tests/*schematest
validate the particular syntax choices being codified here, so we don't
regress in the future.
> +++ b/docs/schemas/storagepool.rng
> @@ -178,10 +178,10 @@
> <ref name='unsignedInt'/>
> </element>
> <element name='owner'>
> - <ref name='unsignedInt'/>
> + <data type='int'/>
Is -1 the only valid negative value? If so, this might be better as:
<element name='owner'>
<choice>
<ref name='unsignedInt'/>
<value>-1</value>
</choice>
</element>
--
Eric Blake [email protected] +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
