On 11/30/2012 01:26 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <[email protected]> > > Move the code for matching hostdev instances out of virDomainHostdevFind > and into virDomainHostdevMatch method, which in turn calls out to other > helper methods depending on the type of hostdev. > > Signed-off-by: Daniel P. Berrange <[email protected]> > --- > src/conf/domain_conf.c | 108 > +++++++++++++++++++++++++++++-------------------- > 1 file changed, 65 insertions(+), 43 deletions(-)
Looks like a reasonable refactor. It adds lines, but will make future tweaks to a single hostdev type easier and less nested. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
