On 08/12/2013 02:13 PM, Guido Günther wrote: > otherwise having a strict --no-copy-dt-needed-entries fails in several > places like: > > otherwise we fail like: > > CCLD virdbustest > /usr/bin/ld: virdbustest-virdbustest.o: undefined reference to symbol > 'dbus_message_unref' > /lib/x86_64-linux-gnu/libdbus-1.so.3: error adding symbols: DSO missing > from command line > collect2: error: ld returned 1 exit status > --- > src/Makefile.am | 5 ++++- > tests/Makefile.am | 10 +++++----- > 2 files changed, 9 insertions(+), 6 deletions(-)
ACK with one nit:
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 7e24c1f..074ab18 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1119,7 +1120,8 @@ libvirt_driver_qemu_impl_la_CFLAGS = \
> libvirt_driver_qemu_impl_la_LDFLAGS = $(AM_LDFLAGS)
> libvirt_driver_qemu_impl_la_LIBADD = $(CAPNG_LIBS) \
> $(GNUTLS_LIBS) \
> - $(LIBNL_LIBS)
> + $(LIBNL_LIBS) \
> + $(LIBXML_LIBS)
If you wouldn't mind, write this one as:
$(LIBNL_LIBS) \
$(LIBXML_LIBS) \
$(NULL)
so that next time we touch this, we only have to add one line instead of
modify an existing line.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
