From: "Daniel P. Berrange" <[email protected]> The virVMXFormatConfig called virVMXEscapeHexPipe but forgot to check for OOM. This caused data to silently be lost.
Signed-off-by: Daniel P. Berrange <[email protected]> --- src/vmx/vmx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 5c2c794..38b7cc0 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -3096,7 +3096,8 @@ virVMXFormatConfig(virVMXContext *ctx, virDomainXMLOptionPtr xmlopt, virDomainDe /* def:description -> vmx:annotation */ if (def->description != NULL) { - annotation = virVMXEscapeHexPipe(def->description); + if (!(annotation = virVMXEscapeHexPipe(def->description))) + goto cleanup; virBufferAsprintf(&buffer, "annotation = \"%s\"\n", annotation); } -- 1.8.3.1 -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
