On 11/06/2013 07:05 PM, Michal Privoznik wrote: > One of my previous patches (c7ac2519b7f) did try to fix the issue when > domain dies too soon during migration. However, this clumsy approach was > missing removal of qemuProcessHandleMonitorDestroy resulting in double > unrefing of mon->vm and hence producing the daemon crash: >
> > Signed-off-by: Michal Privoznik <[email protected]> > --- > src/qemu/qemu_process.c | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > @@ -1403,7 +1394,7 @@ qemuConnectMonitor(virQEMUDriverPtr driver, > virDomainObjPtr vm, int logfd) > } > > /* Hold an extra reference because we can't allow 'vm' to be > - * deleted while the monitor is active */ > + * deleted while the monitor is unlocked */ This seems wrong, how about "deleted unitl the monitor gets its own reference"? > virObjectRef(vm); > > ignore_value(virTimeMillisNow(&priv->monStart)); ACK
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
