On 12/11/2013 08:38 PM, Doug Goldstein wrote: > On Wed, Dec 11, 2013 at 9:10 PM, Eric Blake <[email protected]> wrote: >> Adding output to 'virsh --version=long' makes it easier to >> tell if a distro built with particular libraries (it doesn't >> tell you what a remote libvirtd is built with, but is still >> better than nothing). >>
>>From a code stand point this is fine. But the commit subject and > message are ambiguous and don't really explain what you're doing. It > seems like you're adding all storage compile options into the output > when really they were there already and just Gluster was missing. > Wouldn't be better to say "storage: show gluster option in virsh > --version=long"? Sure, that sounds nicer. > > I realize I'm nitpicking the commit message/subject, the code is fine > so ACK from that stand point. Amended and pushed -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
