On 12/20/2013 11:10 AM, John Ferlan wrote: > Commit id '4313fead' added a call to virDomainPanicCheckABIStability() > which did not check whether the panic device existed before making a call > to virDomainDeviceInfoCheckABIStability() which ended up segfaulting: >
> Signed-off-by: John Ferlan <[email protected]> > --- > > +++ b/src/conf/domain_conf.c > @@ -13709,6 +13709,9 @@ static bool > virDomainPanicCheckABIStability(virDomainPanicDefPtr src, > virDomainPanicDefPtr dst) > { > + if (!src && !dst) > + return true; > + > return virDomainDeviceInfoCheckABIStability(&src->info, &dst->info); Still crashes. Minimal reproducer: virsh save $dom $file virsh save-image-edit $file add (or remove) a <panic/> line This should fail ABI compatibility, not crash libvirtd. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
