On 01/02/2014 05:36 PM, John Ferlan wrote: > > > On 12/28/2013 11:11 AM, Eric Blake wrote: >> While all errors related to invalid secrets appeared to be >> consistent, we might as well continue the trend of using a >> common macro. For now, we don't need virCheckSecretGoto(). >> >> * src/datatypes.h (virCheckSecretReturn): New macro. >> (VIR_IS_SECRET, VIR_IS_CONNECTED_SECRET): Drop unused macros. >> * src/libvirt.c: Use macro throughout. >> (virLibSecretError): Drop unused macro. >> >> Signed-off-by: Eric Blake <[email protected]> >> --- >> src/datatypes.h | 17 ++++++++++--- >> src/libvirt.c | 79 >> +++++++++++++++------------------------------------------ >> 2 files changed, 33 insertions(+), 63 deletions(-) >> > > Similar to previous the GetUUIDString, GetUsageType, and GetUsageID > functions now require a valid connection... although GetUUID checked the > connection in the old code. >
And as before, an updated commit message mentions it is intentional. > > ACK > Pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
