On 03/21/2014 04:45 PM, Laine Stump wrote: > On 03/19/2014 11:20 AM, Eric Blake wrote: >> It's finally time to start tracking disk backing chains in >> <domain> XML. The first step is to start refactoring code >> so that we have an object more convenient for representing >> each host source resource in the context of a single guest >> <disk>. Ultimately, I plan to move the new type into src/util >> where it can be reused by virStorageFile, but to make the >> transition easier to review, this patch just creates the >> new type then fixes everything until it compiles again. > > Okay, ACK to this too. It appears to be completely mechanical changes, > so the compiler is just as good a reviewer as I am (I examined to see if > there was anything that looked like more than using a different name for > something (didn't see anything), and compiled successfully. > > So the entire series is fine except the leaks in 15/18.
Thanks; I've pushed the series now with those fixes included. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
