On 05/05/2014 11:54 AM, Michal Privoznik wrote: > When creating a new volume, it is possible to copy data into it from > another already existing volume (referred to as @origvol). Obviously, > the read-only access to @origvol is required, which is thread safe > (probably not performance-wise though). However, with current code > both @newvol and @origvol are marked as building for the time of > copying data from the @origvol to @newvol. The rationale behind > is to disallow some operations on both @origvol and @newvol, e.g. > vol-wipe, vol-delete, vol-download. While it makes sense to not allow > such operations on partly copied mirror, but it doesn't make sense to
> disallow vol-create on the source (@origvol). Maybe mention vol-download next to vol-create? > > Signed-off-by: Michal Privoznik <[email protected]> > --- > > diff to v2: > - changed the error message if volume is in use > - reworded commit message > > src/conf/storage_conf.h | 1 + > src/storage/storage_driver.c | 32 ++++++++++++++++++++++++++++++-- > 2 files changed, 31 insertions(+), 2 deletions(-) ACK Jan
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
