Daniel P. Berrange wrote:

> On Wed, Apr 23, 2014 at 07:50:09PM +0400, Roman Bogorodskiy wrote:
> > Support events for these functions:
> > 
> >  - domainDefineXML
> >  - domainUndefine
> >  - domainCreate{WithFlags,XML}
> >  - domainDestroy
> > ---
> >  src/bhyve/bhyve_driver.c | 88 
> > +++++++++++++++++++++++++++++++++++++++++++++++-
> >  src/bhyve/bhyve_utils.h  |  3 ++
> >  2 files changed, 90 insertions(+), 1 deletion(-)
> 
> ACK, with one tweak
> 
> > @@ -727,8 +746,16 @@ bhyveDomainCreateWithFlags(virDomainPtr dom,
> >                                 VIR_DOMAIN_RUNNING_BOOTED,
> >                                 start_flags);
> >  
> > +    if (ret == 0) {
> > +        event = virDomainEventLifecycleNewFromObj(vm,
> > +                                                  VIR_DOMAIN_EVENT_STARTED,
> > +                                                  
> > VIR_DOMAIN_EVENT_STARTED_BOOTED);
> > +    }
> 
> Nit-pick - no need for curly brackets here

Pushed with this fix and s/1.2.4/1.2.5/ for the new functions; thanks!

Roman Bogorodskiy

Attachment: pgpdas_Dn0_wJ.pgp
Description: PGP signature

--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to