On Sat, May 24, 2014 at 10:09:05AM +0200, Timm Bäder wrote: > On 21.05, Daniel P. Berrange wrote: > > On Tue, May 20, 2014 at 08:56:24PM +0200, Timm Bäder wrote: > > > The code seems to be fine. > > > --- > > > > > > I'd like to use this code (in later patches). If anything is wrong > > > with the current implementation, I'd like to know so I can fix it. > > > > This is just historical cruft. IIRC, I had #if 0'd it, because at the > > time I wrote this, virDomainSnapshotRef didn't exist, but this is long > > since added. > > > > > > Regards, > > Daniel > > Well, that's even better, thanks. Is that patch OK in its current form?
This looks good yes, ACK and will be pushed soon. Christophe
pgp6Cye21Voxd.pgp
Description: PGP signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
