On 06/25/2014 10:54 AM, Peter Krempa wrote:
> Add functions that will allow to set all the required cgroup stuff on
> individual images taking a virStorageSourcePtr. Also convert functions
> designed to setup whole backing chain to take advantage of the chagne.

s/chagne/change/

> ---
>  src/qemu/qemu_cgroup.c | 104 
> ++++++++++++++++++++++++-------------------------
>  src/qemu/qemu_cgroup.h |   3 ++
>  2 files changed, 55 insertions(+), 52 deletions(-)
> 

> +int
> +qemuSetImageCgroup(virDomainObjPtr vm,
> +                   virStorageSourcePtr src,
> +                   bool deny)

Bikeshedding: I would have named it 'bool allow' and flipped the logic
(that is, passing true to turn on the cgroup, false to turn it back
off).  What you have works, though, so I won't insist.

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to