On 06/27/2014 04:37 PM, Jincheng Miao wrote: > The default graphics channel mode is 'any', so as to defaultMode attribute. > If defaultMode and channel mode are all the default value 'any', > qemuConnectDomainXMLToNative will set TLSPort. > But in qemuBuildGraphicsSPICECommandLine, if spice_tls is not enabled, > libvirtd > will report an error to tell the user that spice TLS is disabled in qemu.conf. > > So qemuConnectDomainXMLToNative should check spice_tls is enabled, > then decide to allocate an tlsPort number to this graphics. > > If user specified defaultMode is 'secure', qemuConnectDomainXMLToNative > could allocate tlsPort, and then let qemuBuildGraphicsSPICECommandLine reports > the spice_tls disabled error. > > The related bug is: > https://bugzilla.redhat.com/show_bug.cgi?id=1113868 > > Signed-off-by: Jincheng Miao <jm...@redhat.com> > --- > src/qemu/qemu_driver.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) >
ACK, I will push this later. Jan
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
