On 07/11/2014 06:35 AM, John Ferlan wrote: > Add a conn for future patches to be able to grab the secret when > authenticating an iSCSI host device > > Signed-off-by: John Ferlan <[email protected]> > --- > src/qemu/qemu_command.c | 5 +++-- > src/qemu/qemu_command.h | 5 +++-- > src/qemu/qemu_driver.c | 6 +++--- > src/qemu/qemu_hotplug.c | 34 ++++++++++++++++++++-------------- > src/qemu/qemu_hotplug.h | 9 ++++++--- > 5 files changed, 35 insertions(+), 24 deletions(-)
I'm not sure if our goal has been to get rid of passing the conn through by having smarter callbacks, but if it is, this moves in the opposite direction. But this patch is clean code-wise, as long as there are no major design concerns. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
