On 5/11/23 20:19, Simon Fairweather wrote: > Hi Michal, > > Would you be able to add, if there is a process you follow I can look at > creating merge requests. > > Regards > Simon > > int virDomainBlockPull (virDomainPtr > <https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainPtr> dom, > const char * disk, > unsigned long bandwidth, > unsigned int flags) > > > int virDomainBlockCopy (virDomainPtr > <https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainPtr> dom, > const char * disk, > const char * destxml, > virTypedParameterPtr > <https://libvirt.org/html/libvirt-libvirt-common.html#virTypedParameterPtr> > params, > int nparams, > unsigned int > flags)intvirDomainBlockPull (virDomainPtr > <https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainPtr>dom, > > > On Wed, May 3, 2023 at 12:42 PM Michal Prívozník <mpriv...@redhat.com > <mailto:mpriv...@redhat.com>> wrote: > > On 4/30/23 20:29, Simon Fairweather wrote: > > Hi Michal > > > > Are there plans to implement snapshot create_as version of the > > following function where XML could be passed? > > Honestly, there are no plans for libvirt-php. I maintain it in my spare > time and implement features as somebody requests them. Let me implement > it. And also fix the issue you've filled earlier this week. > > Michal >
Posted as: https://gitlab.com/libvirt/libvirt-php/-/merge_requests/39 Michal
