Sat Jun 09 07:20:25 2012: Request 77525 was acted upon.
Transaction: Correspondence added by COSIMO
       Queue: Win32-API
     Subject: new release - version 0.69
   Broken in: (no value)
    Severity: Wishlist
       Owner: Nobody
  Requestors: bul...@hotmail.com
      Status: open
 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77525 >


I have read most of your patch.

It's somewhat difficult to digest all the changes together.
I think it would have been easier to get a series of commits, maybe in a 
forked git repository (hint :)

I'm impressed by the amount of work you did. I'd like someone else to 
have a look at this patch, but my feedback is:

* Not sure the Win32::API/Win32::API::More namespace split is the best 
solution. I'd suggest reaching out to Win32::API users to estimate how 
much work it would be to change "Ss" for short ints.
* Please avoid the WIN32_API_SORRY_I_WAS_AN_IDIOT variable, and rename it 
to something that explains the purpose of it.

Reply via email to