On Thu, Oct 10, 2013 at 6:25 PM, bulk 88 <[email protected]> wrote:
> Is https://github.com/cosimo/perl5-win32-api/pull/11 a bug fix or just code
> cleanup/refactor? I think it is just
> cleanup for prettyness.
I was hoping to make clear in the commit message that it actualy *is*
a bug fix. The original code has
length($dlib)-$pos+length('CCFLAGS = ')
which should actually be
length($dlib)-($pos+length('CCFLAGS = '))
Note the parenthesis. In the same run I've simplified the code a bit
to not recalculate $pos+length('CCFLAGS = ') multiple times.
> In regards to #11, do you want your commit under your name or not in git? I
> don't care too much so its
> upto you.
As it's an unrelated bug fix I'd like to keep it as a separate commit.
And also to maintain my authorship. Feel free to cherry-pick the
commit. If it's of any help to you I can also create the same pull
request for your fork.
> I plan to squash
> 3ef519b70431eef01859f859b8a7c4ea3a457f3c "remove "package
> ExtUtils::MM_Win32;" uses" onto
> the previous commit 865055254afb2161b0dc634fb11779fbecb15d0d "old < ~6.25
> MakeMakers made a bad makefile, Changes update for contribs". collapse your
> pull #11 commit onto those 2 and give you just changes file credit, or
> keep it a separate commit?
Why squash the commits? Strictly spoken they are unrelated, because
the one is about old MakeMaker versions (not necessarily from MSYS),
and the other one for MSYS / old Perl compatibility. But it's of
course up to you.
> So basically, when you respond, I'll squash the commits, then have cosimo
> merge it. Do you require a CPAN
> release or can you live with a github checkout?
I'd require a CPAN release. Maybe you could do something like a 0.75.1
release which just adds MSYS support?
Thanks in advance!
--
Sebastian Schuberth
